Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back --cors option #527

Merged
merged 5 commits into from Dec 30, 2019
Merged

Add back --cors option #527

merged 5 commits into from Dec 30, 2019

Conversation

TrevorDev
Copy link
Contributor

@TrevorDev
Copy link
Contributor Author

@leo @styfle can someone take a look at this. Is anything else needed to get this merged?

@ltouro
Copy link

ltouro commented Oct 8, 2019

can we release this? having a cors option is really usefull

@TrevorDev
Copy link
Contributor Author

@leo @styfle Merge plz

@leo leo changed the title add back cors option Add back --cors option Dec 30, 2019
leo
leo approved these changes Dec 30, 2019
View reviewed changes
Copy link
Contributor

@leo leo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like quite a lot of people are in need of that option. Let's bring it back!

@leo leo merged commit 6213de8 into vercel:master Dec 30, 2019
@snyk-bot snyk-bot mentioned this pull request Mar 26, 2020
Merged
@crhistianramirez crhistianramirez mentioned this pull request May 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@developit developit developit approved these changes

@leo leo leo approved these changes

@anmdotdev anmdotdev anmdotdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@TrevorDev @ltouro @developit @leo @anmdotdev