Fix building server-side generated AMP pages #13046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slawekkolodziej
requested review from
ijjk,
lfades,
Timer and
timneutkens
as code owners
Stats from current PRDefault Server Mode (Increase detected
|
| zeit/next.js canary | slawekkolodziej/next.js fix-ssg-amp-export | Change | |
|---|---|---|---|
| buildDuration | 11.5s | 11.4s | -52ms |
| nodeModulesSize | 58.5 MB | 58.5 MB |
Page Load Tests Overall increase ✓
| zeit/next.js canary | slawekkolodziej/next.js fix-ssg-amp-export | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 1.953 | 1.887 | -0.07 |
| / avg req/sec | 1279.78 | 1324.86 | |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.097 | 1.078 | -0.02 |
| /error-in-render avg req/sec | 2279.25 | 2320.15 |
Client Bundles (main, webpack, commons)
| zeit/next.js canary | slawekkolodziej/next.js fix-ssg-amp-export | Change | |
|---|---|---|---|
| main-HASH.js gzip | 6.71 kB | 6.71 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..310a.js gzip | 10.5 kB | 10.5 kB | ✓ |
| framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 57 kB | 57 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| zeit/next.js canary | slawekkolodziej/next.js fix-ssg-amp-export | Change | |
|---|---|---|---|
| main-HASH.module.js gzip | 5.74 kB | 5.74 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..dule.js gzip | 6.86 kB | 6.86 kB | ✓ |
| framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 52.5 kB | 52.5 kB | ✓ |
Legacy Client Bundles (polyfills)
| zeit/next.js canary | slawekkolodziej/next.js fix-ssg-amp-export | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 26.3 kB | 26.3 kB | ✓ |
| Overall change | 26.3 kB | 26.3 kB | ✓ |
Client Pages
| zeit/next.js canary | slawekkolodziej/next.js fix-ssg-amp-export | Change | |
|---|---|---|---|
| _app.js gzip | 1.26 kB | 1.26 kB | ✓ |
| _error.js gzip | 3.28 kB | 3.28 kB | ✓ |
| hooks.js gzip | 881 B | 881 B | ✓ |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js gzip | 2.06 kB | 2.06 kB | ✓ |
| routerDirect.js gzip | 279 B | 279 B | ✓ |
| withRouter.js gzip | 278 B | 278 B | ✓ |
| Overall change | 8.26 kB | 8.26 kB | ✓ |
Client Pages Modern
| zeit/next.js canary | slawekkolodziej/next.js fix-ssg-amp-export | Change | |
|---|---|---|---|
| _app.module.js gzip | 604 B | 604 B | ✓ |
| _error.module.js gzip | 2.09 kB | 2.09 kB | ✓ |
| hooks.module.js gzip | 383 B | 383 B | ✓ |
| index.module.js gzip | 223 B | 223 B | ✓ |
| link.module.js gzip | 1.52 kB | 1.52 kB | ✓ |
| routerDirect..dule.js gzip | 281 B | 281 B | ✓ |
| withRouter.m..dule.js gzip | 278 B | 278 B | ✓ |
| Overall change | 5.38 kB | 5.38 kB | ✓ |
Client Build Manifests
| zeit/next.js canary | slawekkolodziej/next.js fix-ssg-amp-export | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 61 B | 61 B | ✓ |
| _buildManife..dule.js gzip | 61 B | 61 B | ✓ |
| Overall change | 122 B | 122 B | ✓ |
Rendered Page Sizes
| zeit/next.js canary | slawekkolodziej/next.js fix-ssg-amp-export | Change | |
|---|---|---|---|
| index.html gzip | 927 B | 927 B | ✓ |
| link.html gzip | 937 B | 937 B | ✓ |
| withRouter.html gzip | 923 B | 923 B | ✓ |
| Overall change | 2.79 kB | 2.79 kB | ✓ |
Serverless Mode
General Overall increase ⚠️
| zeit/next.js canary | slawekkolodziej/next.js fix-ssg-amp-export | Change | |
|---|---|---|---|
| buildDuration | 12.3s | 12.4s | |
| nodeModulesSize | 58.5 MB | 58.5 MB |
Client Bundles (main, webpack, commons)
| zeit/next.js canary | slawekkolodziej/next.js fix-ssg-amp-export | Change | |
|---|---|---|---|
| main-HASH.js gzip | 6.71 kB | 6.71 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..310a.js gzip | 10.5 kB | 10.5 kB | ✓ |
| framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 57 kB | 57 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| zeit/next.js canary | slawekkolodziej/next.js fix-ssg-amp-export | Change | |
|---|---|---|---|
| main-HASH.module.js gzip | 5.74 kB | 5.74 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..dule.js gzip | 6.86 kB | 6.86 kB | ✓ |
| framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 52.5 kB | 52.5 kB | ✓ |
Legacy Client Bundles (polyfills)
| zeit/next.js canary | slawekkolodziej/next.js fix-ssg-amp-export | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 26.3 kB | 26.3 kB | ✓ |
| Overall change | 26.3 kB | 26.3 kB | ✓ |
Client Pages
| zeit/next.js canary | slawekkolodziej/next.js fix-ssg-amp-export | Change | |
|---|---|---|---|
| _app.js gzip | 1.26 kB | 1.26 kB | ✓ |
| _error.js gzip | 3.28 kB | 3.28 kB | ✓ |
| hooks.js gzip | 881 B | 881 B | ✓ |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js gzip | 2.06 kB | 2.06 kB | ✓ |
| routerDirect.js gzip | 279 B | 279 B | ✓ |
| withRouter.js gzip | 278 B | 278 B | ✓ |
| Overall change | 8.26 kB | 8.26 kB | ✓ |
Client Pages Modern
| zeit/next.js canary | slawekkolodziej/next.js fix-ssg-amp-export | Change | |
|---|---|---|---|
| _app.module.js gzip | 604 B | 604 B | ✓ |
| _error.module.js gzip | 2.09 kB | 2.09 kB | ✓ |
| hooks.module.js gzip | 383 B | 383 B | ✓ |
| index.module.js gzip | 223 B | 223 B | ✓ |
| link.module.js gzip | 1.52 kB | 1.52 kB | ✓ |
| routerDirect..dule.js gzip | 281 B | 281 B | ✓ |
| withRouter.m..dule.js gzip | 278 B | 278 B | ✓ |
| Overall change | 5.38 kB | 5.38 kB | ✓ |
Client Build Manifests
| zeit/next.js canary | slawekkolodziej/next.js fix-ssg-amp-export | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 61 B | 61 B | ✓ |
| _buildManife..dule.js gzip | 61 B | 61 B | ✓ |
| Overall change | 122 B | 122 B | ✓ |
Serverless bundles
| zeit/next.js canary | slawekkolodziej/next.js fix-ssg-amp-export | Change | |
|---|---|---|---|
| _error.js | 850 kB | 850 kB | ✓ |
| 404.html | 4.18 kB | 4.18 kB | ✓ |
| hooks.html | 3.81 kB | 3.81 kB | ✓ |
| index.js | 851 kB | 851 kB | ✓ |
| link.js | 888 kB | 888 kB | ✓ |
| routerDirect.js | 880 kB | 880 kB | ✓ |
| withRouter.js | 880 kB | 880 kB | ✓ |
| Overall change | 4.36 MB | 4.36 MB | ✓ |
ijjk
approved these changes
May 18, 2020
|
Awesome! Yeah, good job with adding those tests, next time I'll definitely take care of this 😄Also I didn't realize that we can have different data files for amp & normal page, but it makes sense. Any chance this gets released in 9.4.2? |
chibicode
pushed a commit
to chibicode/next.js
that referenced
this pull request
May 21, 2020
rokinsky
pushed a commit
to rokinsky/next.js
that referenced
this pull request
Jul 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue that I reported earlier: #13038
Long story short, without this PR
next buildfails when you try to build ssg amp pages.