Skip to content

Fix up CMS examples #12840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2020
Merged

Fix up CMS examples #12840

merged 1 commit into from
May 13, 2020
+15 −15

Conversation

Timer
Copy link
Member

@Timer Timer commented May 13, 2020

This change ensures we do not pass undefined values into the getStaticProps return object.

Fixes #12806
Fixes #12798

@Timer Timer added the examples Issue was opened via the examples template. label May 13, 2020
@Timer Timer added this to the 9.4.1 milestone May 13, 2020
@Timer Timer requested a review from chibicode May 13, 2020 16:02
@Timer Timer requested a review from lfades as a code owner May 13, 2020 16:02
@ijjk
Copy link
Member

ijjk commented May 13, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
zeit/next.js canary Timer/next.js examples-fix Change
buildDuration 11s 11.1s ⚠️ +132ms
nodeModulesSize 58.7 MB 58.7 MB ✓
Page Load Tests Overall increase ✓
zeit/next.js canary Timer/next.js examples-fix Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.826 1.817 -0.01
/ avg req/sec 1368.85 1375.71 ⚠️ +6.86
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.071 1.045 -0.03
/error-in-render avg req/sec 2335.14 2391.34 ⚠️ +56.2
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js examples-fix Change
main-HASH.js gzip 6.68 kB 6.68 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..e49d.js gzip 10.4 kB 10.4 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js examples-fix Change
main-HASH.module.js gzip 5.72 kB 5.72 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js examples-fix Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary Timer/next.js examples-fix Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.29 kB 3.29 kB ✓
hooks.js gzip 880 B 880 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 280 B 280 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.26 kB 8.26 kB ✓
Client Pages Modern
zeit/next.js canary Timer/next.js examples-fix Change
_app.module.js gzip 599 B 599 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 279 B 279 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
zeit/next.js canary Timer/next.js examples-fix Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary Timer/next.js examples-fix Change
index.html gzip 927 B 927 B ✓
link.html gzip 937 B 937 B ✓
withRouter.html gzip 923 B 923 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General
zeit/next.js canary Timer/next.js examples-fix Change
buildDuration 12.8s 12.5s -292ms
nodeModulesSize 58.7 MB 58.7 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js examples-fix Change
main-HASH.js gzip 6.68 kB 6.68 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..e49d.js gzip 10.4 kB 10.4 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js examples-fix Change
main-HASH.module.js gzip 5.72 kB 5.72 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js examples-fix Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary Timer/next.js examples-fix Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.29 kB 3.29 kB ✓
hooks.js gzip 880 B 880 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 280 B 280 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.26 kB 8.26 kB ✓
Client Pages Modern
zeit/next.js canary Timer/next.js examples-fix Change
_app.module.js gzip 599 B 599 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 279 B 279 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
zeit/next.js canary Timer/next.js examples-fix Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary Timer/next.js examples-fix Change
_error.js 850 kB 850 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 851 kB 851 kB ✓
link.js 888 kB 888 kB ✓
routerDirect.js 880 kB 880 kB ✓
withRouter.js 880 kB 880 kB ✓
Overall change 4.36 MB 4.36 MB ✓

@b-bot
Copy link
Contributor

b-bot commented May 13, 2020

@Timer thanks for this. I've tested and this resolves the serialize error but still returns 404 on slug pages.

@Timer Timer merged commit b41f9ba into vercel:canary May 13, 2020
@Timer Timer deleted the examples-fix branch May 13, 2020 18:13
chibicode pushed a commit to chibicode/next.js that referenced this pull request May 21, 2020
@Timer @chibicode
Fix up CMS examples (vercel#12840)
e3ab21b
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@Timer @rokinsky
Fix up CMS examples (vercel#12840)
7135c2c
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chibicode chibicode

@lfades lfades

Assignees
No one assigned
Labels
examples Issue was opened via the examples template.
Projects
None yet
Milestone
9.4.1
Development

Successfully merging this pull request may close these issues.

Error serializing on homepage and 404 on slug pages in cms-prismic example
4 participants
@Timer @ijjk @b-bot @chibicode