-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow optional arguments for build_command #98
Comments
Would you need to modify The issue I see with the generic build-params is that the common build command is something like I think that the current model would work if zkg.meta was updated to take advantage of env vars. Something like
|
I would have expected that a change to |
We already have the |
I'm having trouble understanding what exactly the problem is and what the suggestions are and how they're different from what can currently be done. The docs for
Then emphasizing that the Given the above, is it currently possible to accomplish what's needed? If it is, but it's just a bit annoying/confusing for users to respond to a prompt when most users can successfully rely on a default behavior, I can see adding a new feature to allow |
I'm in the camp favoring that last suggestion above. User vars are a nice concept and the drawback atm is just inconvenience. I see two downsides when you use a general configure arg like this one:
If we add something to label user vars optional, I think we get what we need here. Personally, I also think it would be nice if user vars were also exposed via command line options, since it seems useful to avoid the prompting, and the jump to environment variables is a bit far. That's why I like the idea of adding something like |
That's essentially what I meant as well.
Agree with this as a nice to have. |
So far the
build_command
of a plugin can only be customized usinguser_vars
. However,user_vars
enforce feedback of the user in all cases. Building the AF_Packet plugin for containers may serve as an example here: In many cases CMake logic can detect reasonable defaults and feedback is not required. Only if someone wants to build using a kernel different from the one of the building environment, manual configuration is required. Something likezkg install zeek-af_packet-plugin --build-params "--with-kernel=/usr/..."
(or a more convenient version) would be nice to have I think.The text was updated successfully, but these errors were encountered: