Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template instantiation removes comments from zkg.meta #120

Open
ckreibich opened this issue Oct 13, 2021 · 0 comments
Open

Template instantiation removes comments from zkg.meta #120

ckreibich opened this issue Oct 13, 2021 · 0 comments

Comments

@ckreibich
Copy link
Member

The template instantiation process will currently read an existing zkg.meta via a configparser.ConfigParser, update it with template metadata, and then write it out again. Config parsers don't preserve comments, so these get dropped in the resulting package. I'm not sure this is a problem, but it is unintuitive. zkg could instead do a sanity check whether the existing zkg.meta has no template and template_vars sections (they shouldn't), and append them like in any text file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant