[Backport release-1.2.0] PartitionId in the logging context #7910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
We have in the RaftContext only the name, which contains the raft group and partition id. Sometimes we just want to have the partition id as an int this introduces this property. (cherry picked from commit ae10d8f)
(cherry picked from commit 7f09cde)
(cherry picked from commit afe41e7)
This context map is used on execution to set the logging context. Per default it just contains the actor name. Later sub classes should fill it with more context. It should make it easier on debugging and improve observability. (cherry picked from commit d7f6d84)
In order to not recreate the map object all the time, we create a map only once on the first call and return that afterwards. (cherry picked from commit 7ff5938)
(cherry picked from commit 0253b97)
(cherry picked from commit 365dbe1)
Add new method which should be overwritten by subclasses in order to add more information on which context the actor is currently running. This method is only on the first time, when the context is not yet filled. (cherry picked from commit 2091b0f)
Returning modifiable map on this method makes it easier to implement sub classes. #getContext will return an umodifiable map (cherry picked from commit b36691d)
(cherry picked from commit f505254)
(cherry picked from commit abb9dc9)
(cherry picked from commit f99ed0d)
(cherry picked from commit b2d3737)
(cherry picked from commit 93c839f)
(cherry picked from commit 4cd49f3)
(cherry picked from commit 741da77)
(cherry picked from commit a1b31c4)
(cherry picked from commit d35fa57)
9 tasks
|
Bors r+ |
|
👎 Rejected by too few approved reviews |
ghost
pushed a commit
that referenced
this pull request
Sep 24, 2021
|
Build failed: |
|
Bors r+ |
|
Build succeeded: |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #7885 to
release-1.2.0.relates to #7859