Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support trilogy adapter #815

Closed
tmimura39 opened this issue Sep 4, 2023 · 7 comments
Closed

Support trilogy adapter #815

tmimura39 opened this issue Sep 4, 2023 · 7 comments

Comments

@tmimura39
Copy link

tmimura39 commented Sep 4, 2023

A new MySQL adapter (trilogy) has been introduced to rails. rails/rails#47880

activerecord-import should also support trilogy.

Trilogy is a client library for MySQL-compatible database servers, designed for performance, flexibility, and ease of embedding.

I have verified that the application works correctly with the following code.

require "active_record/connection_adapters/trilogy_adapter"
require "activerecord-import/adapters/mysql2_adapter"

class ActiveRecord::ConnectionAdapters::TrilogyAdapter
  include ActiveRecord::Import::Mysql2Adapter
end
@jkowens
Copy link
Collaborator

jkowens commented Sep 4, 2023

Any input on PR #811?

@tmimura39
Copy link
Author

Oops, I missed that pull request.

thanks 👍

@zmariscal
Copy link
Contributor

zmariscal commented Sep 5, 2023

I'm currently trying to figure out how to properly test this change. The changes I have currently on my PR works as is with a rather large Rails application.

When running he mysql test in a Docker container I see the following:

201 runs, 289 assertions, 1 failures, 56 errors, 0 skips
rake aborted!

I still need to investigate why the CI is ❌, but I'll try to identify the issue and report back.

@zmariscal
Copy link
Contributor

zmariscal commented Sep 6, 2023

I almost have a 🟢 test running. I discovered a small issue with the Trilogy adapter or composite_primary_keys. Opening a PR against the project to see if I can get that merged. 🤞🏼 I can, after that I can hopefully merge this PR.

@zmariscal
Copy link
Contributor

I have opened a PR around add trilogy support here

@zmariscal
Copy link
Contributor

@jkowens with my PR merged now can we close this issue?

@jkowens
Copy link
Collaborator

jkowens commented Feb 7, 2024

Yep 👍

@jkowens jkowens closed this as completed Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants