Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip optional attributes from null objects during conversion #140

Merged

Conversation

liamcervante
Copy link
Contributor

Very similar change to #135

Object types with optional attributes are only for use as a type
conversion target and are not valid to appear in the type constraint for
a null value.
@apparentlymart
Copy link
Collaborator

Thanks! This makes sense to me, for the same reasons as discussed in #135.

@apparentlymart apparentlymart merged commit 08e8439 into zclconf:main Oct 19, 2022
@liamcervante liamcervante deleted the liamcervante/optional-attributes branch October 20, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants