Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use batch verification for RedJubjub signatures #3666

Closed
daira opened this issue Nov 13, 2018 · 2 comments
Closed

Use batch verification for RedJubjub signatures #3666

daira opened this issue Nov 13, 2018 · 2 comments
Labels
A-crypto Area: Cryptography I-performance Problems and improvements with respect to performance I-SECURITY Problems and improvements related to security.
Projects
Protocol Team Arborist Team
Milestone
Release 5.1.0

Comments

@daira
Copy link
Contributor

daira commented Nov 13, 2018 •
edited

This is similar to batch SNARK verification (#320), and a similar strategy can be used to mitigate the risk of consensus divergence (#320 (comment)). We can either implement them at the same time and use the same experimental feature flag, or we can implement them separately.
@daira daira added I-SECURITY Problems and improvements related to security. A-crypto Area: Cryptography I-performance Problems and improvements with respect to performance labels Nov 13, 2018
@daira
Copy link
Contributor Author

daira commented Nov 13, 2018

Note that sapling-crypto already has an API for batched RedJubjub verification, which was added in zcash/sapling-crypto#80 . There is a ticket zcash/sapling-crypto#82 to improve its performance.

@daira daira changed the title Batch verification for RedDSA signatures Batch verification for RedJubjub signatures Nov 13, 2018
@daira daira changed the title Batch verification for RedJubjub signatures Use batch verification for RedJubjub signatures Nov 13, 2018
@mms710 mms710 added this to Needs Prioritization in Arborist Team Jan 3, 2019
@mms710 mms710 added this to Needs Prioritization in Protocol Team Jan 3, 2019
@str4d str4d added this to the Release 5.1.0 milestone Jun 29, 2023
@str4d
Copy link
Contributor

str4d commented Jun 29, 2023

This was implemented in #6048.

@str4d str4d closed this as completed Jun 29, 2023
Arborist Team automation moved this from Needs Prioritization to Complete Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-crypto Area: Cryptography I-performance Problems and improvements with respect to performance I-SECURITY Problems and improvements related to security.
Projects
Arborist Team
  
Complete
Protocol Team
  
Needs Prioritization
Milestone
Release 5.1.0
Development

No branches or pull requests
2 participants
@daira @str4d