Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zsh completion doesn't show "repo" alias for "project" #333

Closed
forivall opened this issue Sep 3, 2019 · 4 comments · Fixed by #368
Closed

Zsh completion doesn't show "repo" alias for "project" #333

forivall opened this issue Sep 3, 2019 · 4 comments · Fixed by #368
Milestone

Comments

@forivall
Copy link

forivall commented Sep 3, 2019

It looks like it was solved in the upstream (spf13/cobra#669) but your version is pinned at v0.0.0-20180412120829-615425954c3b (I'm not a gopher, so i'm not 100% sure that that's the reason)

@zaquestion
Copy link
Owner

@rsteube Any reason we can't update to the latest cobra? I know we've had some back and forth about cobra versions and intricacies, I can't remember where we landed in the end.

@rsteube
Copy link
Collaborator

rsteube commented Sep 5, 2019

spf13/cobra#884 is needed for the custom completions we used in lab.
Since that takes longer than i was hoping we can reopen #313 to update to the newest cobra.

@rsteube
Copy link
Collaborator

rsteube commented Sep 5, 2019

btw. the change in mentioned PR seems to concern just the bash completion and not zsh so that might eventually still be missing in the new version (at least i don't see any mention of alias in https://github.com/spf13/cobra/blob/master/zsh_completions.go) .

@zaquestion
Copy link
Owner

Thanks for the refresher, I've poked the maintainers on spf13/cobra#884 -- that said sounds like updating cobra won't actually add aliases for zsh, still I wouldn't mind having the functionality for bash :D

@zaquestion zaquestion added this to the 0.18.0 milestone Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants