Skip to content

Added test paramters for scope in client_credentials_grant #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

infohash
Copy link
Contributor

No description provided.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
For extra arguments that can be passed to client credentials flow.

To comply with 4.4.2.  Access Token Request of Client Credentials Grant in  RFC 6749

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Verified

This commit was signed with the committer’s verified signature.
windmgc Keery Nie
…entials-optional-args

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Copy link
Owner

@zamzterz zamzterz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition to cover all cases! 👏

To make it really cover the behavior, the scope value in the token request should also be verified (see review comment for details).

@zamzterz zamzterz merged commit 82e7df6 into zamzterz:main Mar 7, 2022
@infohash infohash deleted the featue/client-crerdentials-optional-args branch March 7, 2022 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants