Limit set size #86
Merged
Limit set size #86
+52
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also switch macos encoding to base64 to increase length limit Signed-off-by: Filip Weiss <me@fiws.net>
Signed-off-by: Filip Weiss <me@fiws.net>
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
Setwith too much data leads to errors and unknown behaviour on macos and windows.This PR limits the passable data on those platforms to known limits.
I also raised the max input on macos by switching to base64 for encoding. It uses a new prefix and also checks for the old one, so it should be backwards compatible.
This fixes #84
Also note that on macos the current behaviour actually interprets the input data as another command after a limit is reached. This could be a security vulnerability but is probably mitigated by the hex encoding.