New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update version to 0.12.4 #40
Conversation
+1 |
+1 |
Some news about merge ? |
@baloran Have you tested this to make it works for you? |
This passed a basic smoke test for me. Also checked the fingerprints against https://wkhtmltopdf.org/downloads.html , they check out! 7ff1b7735599201b6a17725497aa732ba1278ec5 wkhtmltopdf_linux_x86 Does anyone on Mac have a minute to check the darwin fingerprint or can someone tell me how to extract the official wkhtmltox-0.12.4_osx-cocoa-x86-64.pkg on Debian? Thanks! |
@unixmonkey any reason to hold off on merging this PR and publish a new release to rubygems? |
@ownadi Thank you very much for this. I'm sorry it took so long to get merged. I don't quite have the time for this that I used to, but I will try to get any 0.12.5 PR merged more quickly. If anyone would like to help with that once pre-built binaries are available, it would be much appreciated. This new version has been pushed to RubyGems. Please be aware there is a well known issue with this version, but it can be worked around. @baloran, @gkop, @kimyu92, @jeremiahmegel, @matthew342, @Subtletree Thanks for the support and nudging. |
@unixmonkey maybe you can make the project part of an organization (just like https://github.com/wkhtmltopdf maybe wkhtmltopdf_binary_gem/wkhtmltopdf_binary_gem) and add maintainers to that so you are not the only maintainer. If you do not have time for it, someone else might. I have no clue where to get those pre-build binaries otherwise I could add them. |
The prebuilt binaries are available at https://wkhtmltopdf.org/downloads.html It looks like they were updated to As far as I know, only @zakird can add new maintainers. |
I'm happy to add maintainers if there are folks who are actively contributing. I think it's a bit tough to add additional maintainers without seeing any history in the project. |
Update version to 0.12.4
Update version to 0.12.4
Update version to 0.12.4
No description provided.