Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version to 0.12.4 #40

Merged
merged 1 commit into from Jun 11, 2018
Merged

Update version to 0.12.4 #40

merged 1 commit into from Jun 11, 2018

Conversation

ownadi
Copy link
Contributor

@ownadi ownadi commented May 24, 2017

No description provided.

@dwkoogt
Copy link

dwkoogt commented Jul 10, 2017

@avenavo
Copy link

avenavo commented Aug 15, 2017

+1

@baloran
Copy link

baloran commented Jan 25, 2018

Some news about merge ?

@unixmonkey
Copy link
Collaborator

@baloran Have you tested this to make it works for you?

@gkop
Copy link

gkop commented Mar 30, 2018

This passed a basic smoke test for me.

Also checked the fingerprints against https://wkhtmltopdf.org/downloads.html , they check out!

7ff1b7735599201b6a17725497aa732ba1278ec5 wkhtmltopdf_linux_x86
2c075a8f64b0a2efd95cc8ec25f02fa560aa0845 wkhtmltopdf_linux_amd64

Does anyone on Mac have a minute to check the darwin fingerprint or can someone tell me how to extract the official wkhtmltox-0.12.4_osx-cocoa-x86-64.pkg on Debian? Thanks!

@kimyu92
Copy link

kimyu92 commented Jun 11, 2018

@unixmonkey any reason to hold off on merging this PR and publish a new release to rubygems?
https://github.com/wkhtmltopdf/wkhtmltopdf/releases/tag/0.12.5 is out too

@unixmonkey unixmonkey merged commit 24e4309 into zakird:master Jun 11, 2018
@unixmonkey
Copy link
Collaborator

@ownadi Thank you very much for this. I'm sorry it took so long to get merged. I don't quite have the time for this that I used to, but I will try to get any 0.12.5 PR merged more quickly. If anyone would like to help with that once pre-built binaries are available, it would be much appreciated.

This new version has been pushed to RubyGems. Please be aware there is a well known issue with this version, but it can be worked around.

@baloran, @gkop, @kimyu92, @jeremiahmegel, @matthew342, @Subtletree Thanks for the support and nudging.

@sandergroen
Copy link

@unixmonkey maybe you can make the project part of an organization (just like https://github.com/wkhtmltopdf maybe wkhtmltopdf_binary_gem/wkhtmltopdf_binary_gem) and add maintainers to that so you are not the only maintainer. If you do not have time for it, someone else might.

I have no clue where to get those pre-build binaries otherwise I could add them.

@unixmonkey
Copy link
Collaborator

The prebuilt binaries are available at https://wkhtmltopdf.org/downloads.html

It looks like they were updated to 0.12.5 since the last time I looked (yesterday), so it should be pretty straightforward to replace the binaries, update the gem version and changelog, verify the fingerprints and that it still works.

As far as I know, only @zakird can add new maintainers.

@zakird
Copy link
Owner

zakird commented Jun 12, 2018

I'm happy to add maintainers if there are folks who are actively contributing. I think it's a bit tough to add additional maintainers without seeing any history in the project.

@unixmonkey unixmonkey mentioned this pull request Jun 22, 2018
tioteath pushed a commit to magnet-team/wkhtmltopdf-binary that referenced this pull request Jul 28, 2020
parallel588 pushed a commit to parallel588/wkhtmltopdf_binary_gem that referenced this pull request May 20, 2021
parallel588 pushed a commit to parallel588/wkhtmltopdf_binary_gem that referenced this pull request May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants