Locked up after cancelled Print command

[bkidwell]

Summary: Print Note; cancel print; UI is locked up now
Expected result: If you cancel the desktop Print dialog box, Trilium should resume operation normally.

I activated Note Actions → Print Note, then I decided to cancel the Print action. Most of the UI is locked up now. The following things are not responding to input events:

• navigation tree
• Note Actions button
• shortcuts toolbar at top
• everything else I try that isn't the CKEditor frame

I shut down Trilium and restarted it and I was able to immediately experience the same failure in the same way again. Log entries from the last attempt are attached.

"appVersion": "0.34.3" -- Windows desktop build (also 0.35.1; see below comment from bkidwell)
trilium.log

[zadam]

Hello, thanks for the report.

I can't reproduce it (testing on 0.35.1). Did you try perhaps on a different note in case it was perhaps something note content specific?

[bkidwell]

I'll try it with 0.35.1 in a few days, and do my best to find any example test cases that change my result, or any other evidence I can gather. Feel free to reply and ask where I went if it's been a week. :^)

[bkidwell]

I upgraded to the latest release "trilium-windows-x64-0.35.1.zip" and tried it again, and I got the same result.

The page has only a title and one paragraph on it. The selected printer when I CANCELLED the print request was "Microsoft Print to PDF".

I'm running Windows 10 Enterprise 64-bit build 17134.

I didn't try this on another OS platform; I assume if it's a cross-platform issue someone else would have noticed already.

Is there anything else I can say that will help diagnose or make the problem reproducible?

Log file: trilium-2019-10-08.log
Screenshot of the page I tried to print: sandbox-page
Notebook subtree containing the page I tried to print: notebook.tar.zip

[zadam]

Hmm, I see. For me print works fine in windows 10 64 bit as well, also tested with Microsoft Print to PDF.

Not sure what this could be, but I'll try to experiment a bit.

[bkidwell]

This problem is about choosing the Print command and then CANCELING the request -- Doing so causes everything but the CKEditor widget in Trilium to lock up and stop responding. Did you cancel a print command?

[zadam]

Oh, I see, I have overlooked that "cancel" ... so yeah, I can reproduce this problem. Happens only in the desktop version and it turns out it's a bug in electron - electron/electron#20426

[bkidwell]

Wow. So it's been broken in Electron all summer in Electron 5. And no one reported it until this week? I'm glad you easily found the apparent source of the problem.

[TerrapinSoftware]

Easy to reproduce with the electron-quick-start repo. Just add this line to index.html:

<button onclick="window.print()">Click me</button>

Then click the button and choose Cancel. Try to click that button again. No reaction. Also, the devtools breakpoints do not work anymore. Try to set an event listener breakpoint on the click event...

Please increase the priority of this bug. Every electron app that supports printing cal fall victim to complete data loss!

[zadam]

@TerrapinSoftware this should be probably send to the bug in the electron repo, not here ...

[TerrapinSoftware]

Ah yes. Sorry. Done. Added comment to electron bug #20426.

[zadam]

This is now fixed in master with new electron.