Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passing config_buffer option breaks with PyYAML6 due to extra required parameter #11

Closed
Hawk777 opened this issue Jan 14, 2023 · 1 comment
Closed

Passing config_buffer option breaks with PyYAML6 due to extra required parameter #11

Hawk777 opened this issue Jan 14, 2023 · 1 comment

Comments

@Hawk777
Copy link
Contributor

Hawk777 commented Jan 14, 2023

In PyYAML 6, the pyyaml.load function started requiring a second parameter. zconfig.YAMLConfig.load_config calls that function if the config_buffer parameter is passed, and does not provide one, thus failing with PyYAML 6.
@amimoto
Copy link

amimoto commented Feb 7, 2023

Should be resolved

  • Added regression test
  • Switched to using safe_load rather than pyyaml.load.
  • Published v3.0.20230207

@zaberaki zaberaki closed this as completed Feb 8, 2023
zaberaki added a commit that referenced this issue Aug 3, 2023
@zaberaki
FIX: #11
0267c89 
Noted by @chead in [Bug 11](#11). `PyYAML` v6.0 requires `yaml.load` to have a second argument. Switched to using `safe_load` to fix the argument issue as well as a potential security issue.
zaberaki added a commit that referenced this issue Aug 3, 2023
@zaberaki
12084 enable more control over logging (#12)
4188894 
* FIX: #11

Noted by @chead in [Bug 11](#11). `PyYAML` v6.0 requires `yaml.load` to have a second argument. Switched to using `safe_load` to fix the argument issue as well as a potential security issue.

* Better log handling and add support for py3.12

* bump version, add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@amimoto @Hawk777 @zaberaki