Skip to content

emit 'ready' when service worker is ready #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2020

Conversation

bseib
Copy link
Contributor

@bseib bseib commented Sep 30, 2019

Emit the 'ready' event regardless of being on localhost development or
in production. When a service worker is active and ready, emit the
signal.

Fixes #20

Emit the 'ready' event regardless of being on localhost development or
in production. When a service worker is active and ready, emit the
signal.

Fixes yyx990803#20
@assemblethis
Copy link

I approve this PR. I've been using identical code for my PWA, but still trying to understand if there is any logic behind not firing the 'ready' event for localhost.

Copy link

@bastientanesie bastientanesie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This'll enable a consistent ready event across environments (whether it is local or not).

@haoqunjiang
Copy link
Collaborator

Sorry for the late response and thank you so much for the help.
I'll release a new version soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ready event is only triggered on localhost
4 participants