emit 'ready' when service worker is ready #37
Merged
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emit the 'ready' event regardless of being on localhost development or in production. When a service worker is active and ready, emit the signal. Fixes yyx990803#20
|
I approve this PR. I've been using identical code for my PWA, but still trying to understand if there is any logic behind not firing the 'ready' event for localhost. |
assemblethis
approved these changes
Oct 16, 2019
bastientanesie
approved these changes
Nov 15, 2019
haoqunjiang
approved these changes
Mar 10, 2020
|
Sorry for the late response and thank you so much for the help. |
This was referenced Apr 1, 2020
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emit the 'ready' event regardless of being on localhost development or
in production. When a service worker is active and ready, emit the
signal.
Fixes #20