Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linter refactor #4

Closed
yvvki opened this issue Jan 4, 2024 · 0 comments
Closed

Linter refactor #4

yvvki opened this issue Jan 4, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@yvvki
Copy link
Owner

yvvki commented Jan 4, 2024

Currently this project uses the XO linter which is a wrapper to ESLint, but currently the configuration is broken due to the line:

ignores: ['!.*.{cjs, js}'],

This makes the XO includes its own configuration file (.xo-config.cjs) but I will ignore other files (see xojs/xo#673).

We would still use Prettier as it is the formatter for non Javascript files.

Solution

Move the .xo-config.cjs and .prettierrc.cjs configuration to package.json as it is the practice applied in the XO repo.

@yvvki yvvki added the bug Something isn't working label Jan 4, 2024
@yvvki yvvki self-assigned this Jan 4, 2024
@yvvki yvvki closed this as completed in 95b0f29 Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant