Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow rendering options with custom component #45

Open
CodyReichert opened this issue May 18, 2020 · 4 comments
Open

Allow rendering options with custom component #45

CodyReichert opened this issue May 18, 2020 · 4 comments

Comments

@CodyReichert
Copy link

CodyReichert commented May 18, 2020

Hey there great library! Are there any plans to allow rendering the items in the options list with custom components? Or would a PR be accepted?

For example:

<ReactAutocompleteInput
  options={["apple", "banana"]}
  renderOption={opt => <Component>{opt}</Component>}
/>
@yury-dymov
Copy link
Owner

Hi Cody, I am not actively supporting it but I will gladly review and merge good PR

@imbedhead
Copy link

#96 Lil late to the party, but had the same need as OP and created a PR for it. Love the library, hopefully someone else can use my change as well!

@lyleaigbedion
Copy link

@yury-dymov ^

@yury-dymov
Copy link
Owner

Done, sorry for the wait. Unless I misunderstood code changes, we would have to change 52 constant to dynamic item height evaluation for the option item elements and it would be good to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants