Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview's highligt-line may not work in Vim #285

Closed
yuki-yano opened this issue Sep 12, 2021 · 4 comments
Closed

Preview's highligt-line may not work in Vim #285

yuki-yano opened this issue Sep 12, 2021 · 4 comments

Comments

@yuki-yano
Copy link
Owner

Problems summary

(It's working well in my environment.)

The highlight-line returned from bat is not applied when previewing grep and help in Vim.
The --highlight-line option is passed in the preview script.
When I run fzf's --preview from Vim terminal, it is displayed correctly.

Expected

Highlight-line is applied properly in all environments.

Environment Information

  • fzf-preview version (package.json):v2.7.2

  • OS:macOS 10.15.7

  • Vim/Neovim version: Vim 8.2.3403

@biosugar0
Copy link

Maybe, The theme of bat command causes this problem.
スクリーンショット 2021-09-16 22 50 07

@biosugar0
Copy link

ansi theme have not lineHighlight.
sharkdp/bat#1730

@ceuk
Copy link

ceuk commented Nov 24, 2021

It's worth noting that if you set $FZF_PREVIEW_PREVIEW_BAT_THEME to an invalid theme name (case sensitive) it will fall back to ansi (which won't work)

@yuki-yano
Copy link
Owner Author

Fixed: 674db2a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants