Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single quotes not opening before the letter 't' #347

Open
3 tasks done
cl1ntv opened this issue Jan 5, 2023 · 4 comments
Open
3 tasks done

Single quotes not opening before the letter 't' #347

cl1ntv opened this issue Jan 5, 2023 · 4 comments
Labels
pinned issue should not be closed by stalebot

Comments

@cl1ntv
Copy link

cl1ntv commented Jan 5, 2023

goldmark has https://github.com/yuin/goldmark/discussions in github.
You should post only issues here. Feature requests and questions should be posted at discussions.

  • goldmark is fully compliant with the CommonMark. Before submitting issue, you must read CommonMark spec and confirm your output is different from CommonMark online demo.
    • Extensions(Autolink without < >, Table, etc) are not part of CommonMark spec. You should confirm your output is different from other official renderers correspond with an extension.
  • goldmark is not dedicated for Hugo. If you are Hugo user and your issue was raised by your experience in Hugo, you should consider create issue at Hugo repository at first .

Please answer the following before submitting your issue:

  1. What version of goldmark are you using? : 1.5.3
  2. What version of Go are you using? : 1.19.4
  3. What operating system and processor architecture are you using? : Ubuntu 22.04, x86_64
  4. What did you do? : write a word starting with t in apostrophes quotes, such as: 'terrifying', 'turn', 'to do something'
  5. What did you expect to see? : &lsquo terrifying &rsquo
  6. What did you see instead? : &rsquo terrifying &rsquo
  7. Did you confirm your output is different from CommonMark online demo or other official renderer correspond with an extension?: yes

This issue seems to me similar to those raised in #180, which is why I raised it here, not at the Hugo repository. Perhaps this is to do with handling contractions (like 'don't', 'mustn't', and so on)? In any case, as soon as I put anything other than a t after the first apostrophe, it outputs the correct quote (&lsquo), even when I italicise the word, for instance (like 'terrifying')

@github-actions
Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label May 29, 2023
@github-actions
Copy link

This issue was closed because it has been inactive for 14 days since being marked as stale.

@yuin yuin reopened this Jun 13, 2023
@yuin yuin added pinned issue should not be closed by stalebot and removed stale labels Jun 13, 2023
@quite
Copy link

quite commented Jul 14, 2023

I also get only &rsquo; around this eh: try replace: 'eh'

@mwat56
Copy link

mwat56 commented Mar 15, 2024

Ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pinned issue should not be closed by stalebot
Projects
None yet
Development

No branches or pull requests

4 participants