Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CDCSDK] Fix test failures in tsan for TestDynamicTablesAdditionForTableCreatedAfterStream #22405

Closed
yugabyte-ci opened this issue May 15, 2024 · 0 comments
Closed

[CDCSDK] Fix test failures in tsan for TestDynamicTablesAdditionForTableCreatedAfterStream #22405

yugabyte-ci opened this issue May 15, 2024 · 0 comments
Assignees
@Sumukh-Phalgaonkar
Labels
area/cdcsdk CDC SDK jira-originated kind/bug This issue is a bug priority/high High Priority

Comments

@yugabyte-ci
Copy link
Contributor

yugabyte-ci commented May 15, 2024 •
edited by jira bot

Jira Link: DB-11308
@yugabyte-ci yugabyte-ci added area/cdcsdk CDC SDK jira-originated kind/bug This issue is a bug priority/high High Priority labels May 15, 2024
Sumukh-Phalgaonkar added a commit that referenced this issue May 15, 2024
@Sumukh-Phalgaonkar
[#22405] CDCSDK: Fix test failure in tsan
8e7f4da 
Summary:
The diff https://phorge.dev.yugabyte.com/D34788 broke the test TestDynamicTablesAdditionForTableCreatedAfterStream in tsan builds. This was due to a missing `continue` statement in the test while asserting the DDL counts. This diff does not need to be backported since the backports of D34788 were amended with this change and the test passes in 2024.1 and 2024.1.0 branches.
Jira: DB-11308

Test Plan: Jenkins: .*CDCSDKConsumptionConsistentChangesTest.TestDynamicTablesAdditionForTableCreatedAfterStream.*

Reviewers: asrinivasan, siddharth.shah

Reviewed By: asrinivasan

Subscribers: ycdcxcluster

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D35094
svarnau pushed a commit that referenced this issue May 25, 2024
@Sumukh-Phalgaonkar
[#22405] CDCSDK: Fix test failure in tsan
3e0c808 
Summary:
The diff https://phorge.dev.yugabyte.com/D34788 broke the test TestDynamicTablesAdditionForTableCreatedAfterStream in tsan builds. This was due to a missing `continue` statement in the test while asserting the DDL counts. This diff does not need to be backported since the backports of D34788 were amended with this change and the test passes in 2024.1 and 2024.1.0 branches.
Jira: DB-11308

Test Plan: Jenkins: .*CDCSDKConsumptionConsistentChangesTest.TestDynamicTablesAdditionForTableCreatedAfterStream.*

Reviewers: asrinivasan, siddharth.shah

Reviewed By: asrinivasan

Subscribers: ycdcxcluster

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D35094
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sumukh-Phalgaonkar Sumukh-Phalgaonkar

Labels
area/cdcsdk CDC SDK jira-originated kind/bug This issue is a bug priority/high High Priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yugabyte-ci @Sumukh-Phalgaonkar