Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update --help to include newly added command line options #44

Open
ndeodhar opened this issue Jul 30, 2020 · 2 comments
Open

Update --help to include newly added command line options #44

ndeodhar opened this issue Jul 30, 2020 · 2 comments
Assignees

Comments

@ndeodhar
Copy link
Contributor

We've added new command line options like --warehouses, --loaderthreads but they don't show up when we run tpccbenchmark --help:

./tpccbenchmark --help
usage: tpccbenchmark
 -c,--config <arg>              [required] Workload configuration file
    --clear <arg>               Clear all records in the database for this
                                benchmark
    --create <arg>              Initialize the database for this benchmark
 -d,--directory <arg>           Base directory for the result files,
                                default is current directory
    --dialects-export <arg>     Export benchmark SQL to a dialects file
    --execute <arg>             Execute the benchmark workload
 -h,--help                      Print this help
    --histograms                Print txn histograms
 -im,--interval-monitor <arg>   Throughput Monitoring Interval in
                                milliseconds
    --load <arg>                Load data using the benchmark's data
                                loader
 -o,--output <arg>              Output file (default System.out)
    --output-raw <arg>          Output raw data
    --output-samples <arg>      Output sample data
    --runscript <arg>           Run an SQL script
 -s,--sample <arg>              Sampling window
 -ss                            Verbose Sampling per Transaction
 -t,--timestamp                 Each result file is prepended with a
                                timestamp for the beginning of the
                                experiment
 -ts,--tracescript <arg>        Script of transactions to execute
    --upload <arg>              Upload the result
    --uploadHash <arg>          git hash to be associated with the upload
 -v,--verbose                   Display Messages

We should update --help to include the new options as well as remove unused options.

@metonymic-smokey
Copy link

@ndeodhar
I just ran ./tpccbenchmark --help and I think the flags you mentioned showed up:

image

I think this issue can be closed?

@metonymic-smokey
Copy link

metonymic-smokey commented Aug 1, 2021

@psudheer21 @hbhanawat
The -s flag mentioned, even though not valid anymore(attempting to use it gave me an error) is used in the Example section of the README.

The name of the file where we specify database credentials is given asconfig/sample_tpcc_config.xml, but config/ has workload_all.xml instead.

I'm not sure these are issues(just started trying to set this up locally) but just dropping them here in any case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants