Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assigned group(s) for adlist in result #73

Open
thomasmerz opened this issue Mar 21, 2023 · 3 comments
Open

Add assigned group(s) for adlist in result #73

thomasmerz opened this issue Mar 21, 2023 · 3 comments

Comments

@thomasmerz
Copy link
Contributor

It would really be nice to have the assigned group for each adlist also in the resulting table in addition to "id, enabled, total_domains, domains_covered, hits_covered, unique_domains_covered, address" which should also be sortable:

# sqlite3 ./gravity.db "select * from 'group'"
0|1|Default|1604414479|1614120328|The default group
22|1|adult-content|1614119689|1614120454|
23|1|test-group|1637245963|1637245963|for testing before going in production

# sqlite3 ./gravity.db "select * from adlist_by_group order by 1"
1|0
5|0
13|0
19|0
20|0
21|0
23|0
27|0
28|0
30|0
32|0
33|0
34|0
35|0
37|0
42|22
43|0
59|0
60|0
62|0
63|0
64|0
67|0
68|0
69|0
71|22
72|22
73|22
74|0
77|22
80|22
81|22
82|22
82|23
83|0
84|0
85|0
87|0
88|22
89|0
90|0

If I find some time, I will make a PR and tell you when I'm starting before you're also trying to add this enhancement.

@thomasmerz
Copy link
Contributor Author

This would make such "documentation" / grouping much easier ❤️

@yubiuser
Copy link
Owner

The problem I see: the number of assigned groups is unpredictable - we can end up in a veeeery long list.

@thomasmerz
Copy link
Contributor Author

Maybe or maybe not 🤔 I can't think of a usecase to have more groups than adlists oder clients. For example I've only 2 additional groups: one for testing new adliste before adding to the default group and one for the kids.
I'll think about a PR as a prototype for this. Maybe as an optional parameter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants