BUG: fix FRB integration with CylindricalResolutionBuffer #4790
+51
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I need to be reminded what "unitary" units mean |
neutrinoceros
force-pushed
the
viz/bug/cyl/frb_integration
branch
3 times, most recently
from
7ee6a51
to
d772c64
Compare
|
@yt-fido test this please |
neutrinoceros
force-pushed
the
viz/bug/cyl/frb_integration
branch
2 times, most recently
from
98299b7
to
292f278
Compare
neutrinoceros
force-pushed
the
viz/bug/cyl/frb_integration
branch
from
292f278
to
e9d0b3e
Compare
|
Thanks @neutrinoceros , very much appreciate the work on this. The FRB's don't quite match what I'd expect. If I run the following code: import yt
import numpy as np
import matplotlib as mpl
import matplotlib.pyplot as plt
ds = yt.load_sample("bw_polar_2d")
slc = yt.SlicePlot(ds, "z", ("gas", "density"))
frb = slc.data_source.to_frb(width=(4,"cm"),resolution=(512,512),center=(0,0))
minmax = lambda A : (np.nanmin(A).v[()],np.nanmax(A).v[()])
R = frb["r"].in_units("cm")
Theta = frb["theta"].in_units("")
X = R*np.cos(Theta)
Y = R*np.sin(Theta)
rho = frb["density"]
print("R:", minmax(R) )
print("Theta:", minmax(Theta) )
print("X:", minmax(X) )
print("Y:", minmax(Y) )
print("rho:", minmax(rho) )
slc.show()
plt.figure()
plt.imshow(rho)
plt.show()
plt.figure()
plt.hist( np.unique(Theta) )
plt.xlabel("Theta")
plt.ylabel("Counts")
plt.show()I get this output:
Whereas I'd expect |
|
thanks for pointing this out. I'll try to come back to see in a few days. In the meantime any additional feedback is most welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix #4789
This is a proof-of-concept level patch, I want to see how it performs against CI.
I'll need to write the missing bits in
_set_radiusand add an actual test.This is currently based atop #4784PR Checklist