refactor: core pkg uses slog #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
venjiang
reviewed
Dec 16, 2022
venjiang
approved these changes
Dec 20, 2022
* refactor: use slog for yomo pkg * refactor: yomo use slog * refactor(rx): use slog for rx pkg * feat(sfn): change on data log level * fix(zipper): zipper build * fix(zipper): remove unused pkg imports * merge master * fix(client): option logger * fix(option): make option public * fix(sfn): log info * feat: make NewOption public * refactor: example uses slog (#412) * refactor(example): use slog * build: restore go mod * build: restore go mod * doc: fix example doc * fix: example use slog not ylog * build: go mod
Codecov Report
@@ Coverage Diff @@
## master #410 +/- ##
==========================================
+ Coverage 59.44% 59.85% +0.41%
==========================================
Files 41 40 -1
Lines 2796 2830 +34
==========================================
+ Hits 1662 1694 +32
- Misses 1008 1009 +1
- Partials 126 127 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request depends #407