refactor: better client connection state management #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
venjiang
reviewed
Aug 25, 2022
| } | ||
|
|
||
| c.state = ConnStateDisconnected | ||
| c.errc <- err |
There was a problem hiding this comment.
In the BASIC example, if an error is returned here, the client will exit. In previous versions, the server dropped without an error。
venjiang
reviewed
Aug 25, 2022
core/client.go
Outdated
|
|
||
| stream.Close() | ||
| if closeConn { | ||
| c.conn.CloseWithError(yerr.ErrorCodeClientAbort.To(), err.Error()) |
There was a problem hiding this comment.
Should more error type checking be added so that the server knows exactly what the error code is and why? For example, something like this:
if e, ok := err.(*quic.ApplicationError); ok {
c.logger.Printf("%s[%s]connection closed by application error: %v", ClientLogPrefix, c.state, e)
c.conn.CloseWithError(e.ErrorCode, e.Error())
} else if e, ok := err.(*yerr.YomoError); ok {
c.logger.Printf("%s[%s]connection closed by yomo error: %v", ClientLogPrefix, c.state, e)
c.conn.CloseWithError(e.ErrorCode().To(), e.Error())
} else {
c.conn.CloseWithError(yerr.ErrorCodeClientAbort.To(), err.Error())
}
venjiang
reviewed
Aug 25, 2022
| c.conn.CloseWithError(yerr.To(yerr.ErrorCodeRejected), v.Message()) | ||
| c.errc <- errors.New(v.Message()) | ||
| break | ||
| return true, true, errors.New(v.Message()) |
There was a problem hiding this comment.
Is it better to use YomoError? Like this:
return true, true, yerr.New(yerr.ErrorCodeRejected, errors.New(v.Message()))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is