Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: nil pointer error if handshake failed #351

Merged
merged 2 commits into from Jul 16, 2022
Merged

fix: nil pointer error if handshake failed #351

merged 2 commits into from Jul 16, 2022

Conversation

wujunzhuo
Copy link
Collaborator

@wujunzhuo wujunzhuo commented Jul 16, 2022 •
edited by fanweixiao

This change is Reviewable

@wujunzhuo wujunzhuo requested a review from venjiang July 16, 2022 07:02
venjiang
venjiang approved these changes Jul 16, 2022
View reviewed changes
Copy link
Contributor

@venjiang venjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 We should have added some tests to make sure it worked.

@wujunzhuo wujunzhuo merged commit b86d7cb into yomorun:master Jul 16, 2022
@wujunzhuo wujunzhuo deleted the fix/close branch July 16, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@venjiang venjiang venjiang approved these changes

@fanweixiao fanweixiao Awaiting requested review from fanweixiao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wujunzhuo @venjiang