-
Fork, then clone the repo:
git clone git@github.com:your-username/symfony-jsonrpc-http-server.git
-
Make sure everything goes well:
make build make test -
Make your changes (Add/Update tests according to your changes).
-
Make sure tests are still green:
make test -
To check code coverage, launch
make coverage
-
Push to your fork and submit a pull request.
-
Wait for feedback or merge.
Some stuff that will increase your pull request's acceptance:
- Write tests.
- Follow PSR-2 coding style.
- Write good commit messages.
- Do not rebase or squash your commits when a review has been made.