Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatible with Electron 21+ / V8's Memory Cage? #174

Closed
hrueger opened this issue Dec 9, 2022 · 6 comments · Fixed by #195
Closed

Compatible with Electron 21+ / V8's Memory Cage? #174

hrueger opened this issue Dec 9, 2022 · 6 comments · Fixed by #195

Comments

@hrueger
Copy link

hrueger commented Dec 9, 2022

Hi,
I couldn't find any info on whether this is compatible with the Memory Cage of Electron 21+. Is it?
I just don't want to risk that it works on my machine and users of my application are doing something differently and it crashes for them.

@yisibl
Copy link
Owner

yisibl commented Dec 12, 2022

I'm sorry, I don't know much about this.

@hrueger
Copy link
Author

hrueger commented Dec 13, 2022

I just found this, maybe it gives a clue?
napi-rs/napi-rs#1346

@yisibl
Copy link
Owner

yisibl commented Jan 6, 2023

Maybe you can follow this issue: nodejs/node-addon-api#1257

@eexit
Copy link

eexit commented Jan 27, 2023

Hello, I'm trying to use this lib inside an electron app and it gives me this error:

(node:69164) UnhandledPromiseRejectionWarning: Error: Failed to create napi buffer

So I believe it's not compatible.

@Brooooooklyn
Copy link
Collaborator

@yisibl release a new version with the latest NAPI-RS would solve this problem

@eexit
Copy link

eexit commented Jan 30, 2023

Thanks! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants