New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix getControllerId() auto-generated id #398
Conversation
machour
commented
Feb 11, 2019
Q | A |
---|---|
Is bugfix? | yes |
New feature? | no |
Breaks BC? | yes/no (not sure anymore, see #397) |
Tests pass? | yes |
Fixed issues | #397 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should really be an option to bring back the old behavior! Changing the default is fine for 2.1.
2.1 is going to be next release of gii. |
If you look at https://travis-ci.org/yiisoft/yii2-gii/jobs/487945891 for example:
We are clearly not getting the expected PHPUnit version (composer.json asks for
|
Is it using a pre-installed version? travis-ci/docs-travis-ci-com#1016
Is it OK, if I add a property |
By all means, go ahead! |
- set strictInflector to false to enable <2.1.0 behavior
Spot on for the Travis issue @schmunk42, thank you! |
Everything is fine for me too. |
Merged. Thank you! |