Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getControllerId() auto-generated id #398

Merged
merged 7 commits into from Feb 17, 2019
Merged

Conversation

machour
Copy link
Member

@machour machour commented Feb 11, 2019

Q A
Is bugfix? yes
New feature? no
Breaks BC? yes/no (not sure anymore, see #397)
Tests pass? yes
Fixed issues #397

@samdark
Copy link
Member

samdark commented Feb 13, 2019

  1. Need a line for changelog.
  2. Any idea why https://travis-ci.org/yiisoft/yii2-gii/jobs/491799386?

Copy link
Contributor

@schmunk42 schmunk42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should really be an option to bring back the old behavior! Changing the default is fine for 2.1.

@samdark
Copy link
Member

samdark commented Feb 14, 2019

2.1 is going to be next release of gii.

@machour
Copy link
Member Author

machour commented Feb 14, 2019

  1. Changelog line added

  2. There's something wrong with our PHPUnit constraint since b7becd5

If you look at https://travis-ci.org/yiisoft/yii2-gii/jobs/487945891 for example:

  • Installing phpunit/phpunit (6.5.x-dev bac23fe): Downloading (100%)
    ...
    PHPUnit 7.5.1 by Sebastian Bergmann and contributors.

We are clearly not getting the expected PHPUnit version (composer.json asks for < 7)

  1. @schmunk42 sorry I haven't had a chance to revise this PR according to your comment. Since this is going to be shipped in 2.1, is it okay with you as is ?

@schmunk42
Copy link
Contributor

We are clearly not getting the expected PHPUnit version (composer.json asks for < 7)

Is it using a pre-installed version? travis-ci/docs-travis-ci-com#1016

  1. @schmunk42 sorry I haven't had a chance to revise this PR according to your comment. Since this is going to be shipped in 2.1, is it okay with you as is ?

Is it OK, if I add a property $strictInflector = true;?

@machour
Copy link
Member Author

machour commented Feb 14, 2019

Is it OK, if I add a property $strictInflector = true;?

By all means, go ahead!

schmunk42 and others added 2 commits February 14, 2019 23:02
- set strictInflector to false to enable <2.1.0 behavior
@machour
Copy link
Member Author

machour commented Feb 14, 2019

Spot on for the Travis issue @schmunk42, thank you!

@schmunk42
Copy link
Contributor

Everything is fine for me too.
Please go ahead with merging...

@samdark samdark merged commit 505c92d into yiisoft:master Feb 17, 2019
@samdark
Copy link
Member

samdark commented Feb 17, 2019

Merged. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants