Made yii\gii\CodeFile indepdendent of controller context #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
do not apply `$newDirMode` and `$newFileMode` if module is not available. Code uses default umask in that case.
|
What's the use case? |
|
I spotted this when running unit tests for the gii Generator in https://github.com/cebe/yii2-openapi tests fail with setting file permission of 0 if gii module is not mocked. Imo the class should not rely on gii module being there, this makes testing much easier as you do not need to mock a whole yii app ffor testing a gii generator. |
machour
approved these changes
Feb 1, 2019
samdark
approved these changes
Feb 2, 2019
|
Merged. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do not apply
$newDirModeand$newFileModeif module is not available.Code uses default umask in that case.