Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(generators): delete action need yii.js #379

Merged
merged 2 commits into from Sep 11, 2018
Merged

fix(generators): delete action need yii.js #379

merged 2 commits into from Sep 11, 2018

Conversation

zacksleo
Copy link
Contributor

Q A
Is bugfix? yes
New feature? no
Breaks BC? no
Tests pass? yes
Fixed issues

@samdark
Copy link
Member

samdark commented Sep 11, 2018

How to reproduce the issue?

@zacksleo
Copy link
Contributor Author

zacksleo commented Sep 11, 2018 via email

@samdark samdark added the type:bug Bug label Sep 11, 2018
@samdark
Copy link
Member

samdark commented Sep 11, 2018

Looks good. Please add a line for CHANGELOG.md. Thanks.

@zacksleo
Copy link
Contributor Author

Updated.

@samdark samdark merged commit cafe77a into yiisoft:master Sep 11, 2018
@samdark
Copy link
Member

samdark commented Sep 11, 2018

Thanks!

@samdark samdark added this to the 2.0.8 milestone Sep 11, 2018
lav45 added a commit to lav45/yii2-gii that referenced this pull request Oct 24, 2018
@lav45
Merge remote-tracking branch 'upstream/master' into 2.2
9a9049e 
* upstream/master:
  Remove useless import of `Yii` from CRUD generator search model template
  Fixes yiisoft#379: Fixed bug in view page where delete button not work well
  Fixes yiisoft#366: Option to allow standardized class names capitals in model generator
  Fixes yiisoft#327: Fixed bug in Model generator when $baseClass is an abstract class
  Fixes yiisoft#366: Better class and file names for uppercase tables
  Update composer.json (yiisoft#364)
  Fix codestyle (yiisoft#362)
  prepare for next release
  release version 2.0.7
  Register CSRF meta-tags dynamically
  Updated CHANGELOG [ci skip]
  Fixed rules generation for JSON columns
  Removed redundant line from license [skip ci]
  added database version to issue template (yiisoft#352) [skip ci]
  docs/guide-ja revised [ci skip] (yiisoft#349)
  Updated issue template [skip ci]
  Fixes yiisoft#185: Fix bug in Model generators when FKs pointing to non-existing tables
  Fixes yiisoft#340: Fix bug in CRUD SearchModel generator
  Require Yii 2.0.14 (yiisoft#339)

Conflicts:
	composer.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark approved these changes

Assignees
No one assigned
Labels
type:bug Bug
Projects
None yet
Milestone
2.0.8
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zacksleo @samdark