Skip to content

Improve error/exception details when loading fixtures #4314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 30, 2020
Merged

Improve error/exception details when loading fixtures #4314

merged 3 commits into from
Nov 30, 2020

Conversation

marcovtwout
Copy link
Member

Q A
Is bugfix? ✔️
New feature? ✔️
Breaks BC?
Tests pass? ✔️
Fixed issues https://github.com/tremani/yii/pull/1

Changes in this PR:

  • Chg: Exceptions thrown while loading fixtures now contain details about the error location (BBoom)
  • Chg: Missing fixture files now throw exceptions (BBoom)

(@samdark I know that Yii 1 is officially only accepting compatibility fixes, but I figured it could still be useful for the community. This PR comes from our company private repo where it has been integrated for years. We plan to continue Yii 1 support, if that is welcome I'd rather we contribute here instead of only in our private repo. :) Thank you for considering our PR, feel free to reject if it doesn't fit.)

@samdark
Copy link
Member

samdark commented Sep 1, 2020

@marcovtwout we do not plan to actively invest time into 1.1 after next release that adds PHP 8 support (and it was part of a deal "get it done and we'll donate to the Yii fund"). Originally it was planned to end support by the end of the year.

I know that you're around since the very beginning of the project so if you want to take over 1.1 maintenance, we can discuss that.

@marcovtwout
Copy link
Member Author

@samdark I'd be happy to continue contributing to maintainance and compatibility support. :) I'll send you a DM so we can discuss further.

@marcovtwout marcovtwout requested a review from samdark November 27, 2020 13:48
@b1rdex
Copy link
Contributor

b1rdex commented Nov 27, 2020

Hi @marcovtwout,

As you're now a member contributor, you may be interested in adopting some features/bug fixes from my fork: master...b1rdex:master if you have time.

Most of the commits are atomic and can be applied w/o conflicts. But there are also some harmful things like dropping a bunch of files or backwards-incompatible things that should be skipped, be careful.

PS. for anyone who's going to look at it: it's better to do it commit-by-commit rather than a complete diff.

@marcovtwout
Copy link
Member Author

@b1rdex Note that even although we may make some minor changes, focus is still on compatibility and security issues. But we can at least take a look at it. In that case, could you create a new issue and name some of the relevant features/fixes/commits that you think are suitable to be merged?

@samdark samdark added this to the 1.1.23 milestone Nov 27, 2020
@marcovtwout marcovtwout merged commit 39cfe5f into yiisoft:master Nov 30, 2020
@marcovtwout marcovtwout deleted the improve-fixture-loading-with-exceptions branch November 30, 2020 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants