PHP 8 support #4306
Merged
PHP 8 support #4306
+318
−118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
samdark
commented
Aug 5, 2020
samdark
commented
| Q | A |
|---|---|
| Is bugfix? | ✔️ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
| Tests pass? | ✔️ |
| Fixed issues | - |
tillkruss
added a commit
to predis/predis
that referenced
this pull request
Aug 11, 2020
Taken from: yiisoft/yii#4306 by @samdark
tillkruss
added a commit
to predis/predis
that referenced
this pull request
Aug 11, 2020
Taken from: yiisoft/yii#4306 by @samdark
marcovtwout
reviewed
Oct 2, 2020
Comment on lines
+132
to
+136
| if(version_compare(PHP_VERSION,'8.0','>=')) { | ||
| $isArray=$param->getType() && $param->getType()->getName()==='array'; | ||
| } else { | ||
| $isArray = $param->isArray(); | ||
| } |
There was a problem hiding this comment.
Code formatting could be improved a little bit.
Comment on lines
+99
to
+101
| } else { | ||
| $isArray=$param->isArray(); | ||
| } |
There was a problem hiding this comment.
Code formatting could be improved a little bit.
|
fyi use see page 63-65 https://www.slideshare.net/nikita_ppv/php-performance-trivia edit: seems fine for 5.3+ https://3v4l.org/6adjF |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.