Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace abstract BaseView to ViewInterface and ViewTrait + imrpove exception message on getting not exist block or parameter in View and WebView #187

Merged
merged 8 commits into from
Oct 25, 2021
Merged

Replace abstract BaseView to ViewInterface and ViewTrait + imrpove exception message on getting not exist block or parameter in View and WebView #187

merged 8 commits into from
Oct 25, 2021

Conversation

vjik
Copy link
Member

@vjik vjik commented Sep 23, 2021 •
edited
Loading

Q A
Is bugfix? ✔️
New feature? ❌
Breaks BC? ✔️
Fixed issues #185 #189

Need add description for ViewInterface and ViewTrait.

Adopt PRs: yiisoft/view-twig#34

Tests pass in demo application.

After release yiisoft/view also need update version in yiisoft/yii-view.

vjik added 5 commits September 23, 2021 22:09
@vjik
Update dev dependencies

Verified

This commit was signed with the committer’s verified signature.
harshanarayana Harsha Narayana
GPG key ID: F8A9CDA91E84B86A
Verified
Learn about vigilant mode
f8b2d80
@vjik
Replace abstract BaseView to trait + interface

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
e610ccd
@vjik
Improve exception message on get not exist parameter

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
e8cd635
@vjik
Improve exception message on get not exist block
0f2b686
@vjik
changelog
7b64a62
@vjik vjik requested a review from a team September 23, 2021 20:02
@vjik vjik added the status:code review The pull request needs review. label Sep 23, 2021
@vjik vjik changed the title Replace abstract BaseVIew to ViewInterface and ViewTrait + imrpove exception message on getting not exist block or parameter in View and WebView Replace abstract BaseView to ViewInterface and ViewTrait + imrpove exception message on getting not exist block or parameter in View and WebView Sep 23, 2021
@vjik vjik mentioned this pull request Sep 23, 2021
Merged
samdark
samdark reviewed Oct 23, 2021
View reviewed changes
@samdark
Copy link
Member

samdark commented Oct 23, 2021

I'd check/fix #189 and release it as a minor version first.

@vjik
Flush currently being rendered view files on change context via `View…
950181b 
…::withContext()` or `WebView::withContext()`
@vjik
Copy link
Member Author

vjik commented Oct 24, 2021

I'd check/fix #189 and release it as a minor version first.

done

@samdark samdark merged commit b557be7 into master Oct 25, 2021
@samdark samdark deleted the trait branch October 25, 2021 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark

@devanych devanych

Assignees
No one assigned
Labels
status:code review The pull request needs review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vjik @samdark @devanych