Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt UrlGenerator #108

Merged
merged 4 commits into from
Nov 12, 2022
Merged

Adapt UrlGenerator #108

merged 4 commits into from
Nov 12, 2022

Conversation

rustamwin
Copy link
Member

Q A
Is bugfix? ✔️/❌
New feature? ✔️/❌
Breaks BC? ✔️/❌
Fixed issues yiisoft/router#177

Verified

This commit was signed with the committer’s verified signature.
rustamwin Rustam Mamadaminov
@rustamwin rustamwin added the status:code review The pull request needs review. label Nov 11, 2022
@rustamwin rustamwin requested a review from a team November 11, 2022 12:30
@what-the-diff
Copy link

what-the-diff bot commented Nov 11, 2022

  • Added query parameters to generateFromCurrent method
  • Updated tests for new functionality

Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need changelog line.

Verified

This commit was signed with the committer’s verified signature.
rustamwin Rustam Mamadaminov

Verified

This commit was signed with the committer’s verified signature.
rustamwin Rustam Mamadaminov

Verified

This commit was signed with the committer’s verified signature.
rustamwin Rustam Mamadaminov
@codecov
Copy link

codecov bot commented Nov 12, 2022

Codecov Report

Base: 99.45% // Head: 99.46% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (5b926ba) compared to base (32979e4).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #108   +/-   ##
=========================================
  Coverage     99.45%   99.46%           
  Complexity       85       85           
=========================================
  Files             2        2           
  Lines           185      186    +1     
=========================================
+ Hits            184      185    +1     
  Misses            1        1           
Impacted Files Coverage Δ
src/UrlGenerator.php 99.03% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rustamwin rustamwin merged commit 164ef9e into master Nov 12, 2022
@rustamwin rustamwin deleted the adapt-url-generator branch November 12, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants