From 5dbc933af5933df8bee4bee2a999bf86e1b640c5 Mon Sep 17 00:00:00 2001
From: Dietmar Maurer <dietmar@proxmox.com>
Date: Sun, 25 Sep 2022 09:25:42 +0200
Subject: [PATCH] Context: cleanup - avoid storing a copy of children

The new changed() signature allows accessing old_props, so
there is no more need to store an additional copy of children.
---
 packages/yew/src/context.rs | 16 +++++-----------
 1 file changed, 5 insertions(+), 11 deletions(-)

diff --git a/packages/yew/src/context.rs b/packages/yew/src/context.rs
index 3e92c828ded..74514002b79 100644
--- a/packages/yew/src/context.rs
+++ b/packages/yew/src/context.rs
@@ -24,7 +24,6 @@ pub struct ContextProviderProps<T: Clone + PartialEq> {
 #[derive(Debug)]
 pub struct ContextProvider<T: Clone + PartialEq + 'static> {
     context: T,
-    children: Children,
     consumers: RefCell<Slab<Callback<T>>>,
 }
 
@@ -85,20 +84,15 @@ impl<T: Clone + PartialEq + 'static> Component for ContextProvider<T> {
     fn create(ctx: &Context<Self>) -> Self {
         let props = ctx.props();
         Self {
-            children: props.children.clone(),
             context: props.context.clone(),
             consumers: RefCell::new(Slab::new()),
         }
     }
 
-    fn changed(&mut self, ctx: &Context<Self>, _old_props: &Self::Properties) -> bool {
+    fn changed(&mut self, ctx: &Context<Self>, old_props: &Self::Properties) -> bool {
         let props = ctx.props();
-        let should_render = if self.children == props.children {
-            false
-        } else {
-            self.children = props.children.clone();
-            true
-        };
+
+        let should_render = old_props.children != props.children;
 
         if self.context != props.context {
             self.context = props.context.clone();
@@ -108,7 +102,7 @@ impl<T: Clone + PartialEq + 'static> Component for ContextProvider<T> {
         should_render
     }
 
-    fn view(&self, _ctx: &Context<Self>) -> Html {
-        html! { <>{ self.children.clone() }</> }
+    fn view(&self, ctx: &Context<Self>) -> Html {
+        html! { <>{ ctx.props().children.clone() }</> }
     }
 }