From 3412fcc0e5e1259f344eebcee0ac129aa6edf5f1 Mon Sep 17 00:00:00 2001 From: Muhammad Hamza Date: Sun, 7 Aug 2022 23:13:45 +0500 Subject: [PATCH 1/4] onsubmit should be a SubmitEvent --- packages/yew/src/html/listener/events.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/yew/src/html/listener/events.rs b/packages/yew/src/html/listener/events.rs index a1b8677f6d6..398ed53c68d 100644 --- a/packages/yew/src/html/listener/events.rs +++ b/packages/yew/src/html/listener/events.rs @@ -166,7 +166,7 @@ impl_short! { oninput(InputEvent) - onsubmit(FocusEvent) + onsubmit(SubmitEvent) onanimationcancel(AnimationEvent) onanimationend(AnimationEvent) From 316e2320fb9cbb6afab349b53004366108a9d802 Mon Sep 17 00:00:00 2001 From: Muhammad Hamza Date: Sun, 7 Aug 2022 23:35:06 +0500 Subject: [PATCH 2/4] At least v0.3.59 --- packages/yew/Cargo.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/yew/Cargo.toml b/packages/yew/Cargo.toml index 6742ddbbac0..9ce5d9a9507 100644 --- a/packages/yew/Cargo.toml +++ b/packages/yew/Cargo.toml @@ -35,7 +35,7 @@ tokio = { version = "1.19", features = ["sync"] } tokio-stream = { version = "0.1.9", features = ["sync"] } [dependencies.web-sys] -version = "0.3" +version = "^0.3.59" features = [ "AnimationEvent", "Document", From 050e5282cad547c49b78dc5b985ea00580526004 Mon Sep 17 00:00:00 2001 From: Muhammad Hamza Date: Sun, 7 Aug 2022 23:40:24 +0500 Subject: [PATCH 3/4] Enable feature, add re-export --- packages/yew/Cargo.toml | 1 + packages/yew/src/lib.rs | 1 + 2 files changed, 2 insertions(+) diff --git a/packages/yew/Cargo.toml b/packages/yew/Cargo.toml index 9ce5d9a9507..3eac6796400 100644 --- a/packages/yew/Cargo.toml +++ b/packages/yew/Cargo.toml @@ -66,6 +66,7 @@ features = [ "WheelEvent", "Window", "HtmlScriptElement", + "SubmitEvent" ] [target.'cfg(target_arch = "wasm32")'.dependencies] diff --git a/packages/yew/src/lib.rs b/packages/yew/src/lib.rs index a185e2e0e5f..adb3bef711a 100644 --- a/packages/yew/src/lib.rs +++ b/packages/yew/src/lib.rs @@ -309,6 +309,7 @@ pub mod events { pub use web_sys::{ AnimationEvent, DragEvent, ErrorEvent, Event, FocusEvent, InputEvent, KeyboardEvent, MouseEvent, PointerEvent, ProgressEvent, TouchEvent, TransitionEvent, UiEvent, WheelEvent, + SubmitEvent, }; #[cfg(feature = "csr")] From 240ed877858c31881f1a6ccbfeca0f7a2b597c72 Mon Sep 17 00:00:00 2001 From: Muhammad Hamza Date: Sun, 7 Aug 2022 23:50:00 +0500 Subject: [PATCH 4/4] fmt --- packages/yew/src/lib.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/yew/src/lib.rs b/packages/yew/src/lib.rs index adb3bef711a..d387edd950a 100644 --- a/packages/yew/src/lib.rs +++ b/packages/yew/src/lib.rs @@ -308,8 +308,8 @@ pub mod events { #[doc(no_inline)] pub use web_sys::{ AnimationEvent, DragEvent, ErrorEvent, Event, FocusEvent, InputEvent, KeyboardEvent, - MouseEvent, PointerEvent, ProgressEvent, TouchEvent, TransitionEvent, UiEvent, WheelEvent, - SubmitEvent, + MouseEvent, PointerEvent, ProgressEvent, SubmitEvent, TouchEvent, TransitionEvent, UiEvent, + WheelEvent, }; #[cfg(feature = "csr")]