Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align IString/AttrValue with Cow of element #3524

Open
ctron opened this issue Nov 9, 2023 · 0 comments
Open

Align IString/AttrValue with Cow of element #3524

ctron opened this issue Nov 9, 2023 · 0 comments
Labels

Comments

@ctron
Copy link
Contributor

ctron commented Nov 9, 2023

It is possible to set the value of an element using <@{value} />. This seems to be of the type Cow<'static, str>.

However, there also seems to be no IntoPropValue for various string types to Cow<'static, str>, which makes dealing with it a bit cumbersome.

On the other hand AttrValue seems to have solved this just fine.

Maybe a way to deal with this would be to use IString or simply AttrValue for this use case as well. Maybe support Cow<static, str>` would also make sense.

@ctron ctron added the bug label Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant