Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix changelog generator #2958

Merged
merged 1 commit into from Nov 9, 2022
Merged

Fix changelog generator #2958

merged 1 commit into from Nov 9, 2022

Conversation

voidpumpkin
Copy link
Member

Description

  • Fix default file paths
  • Stop fetching the commit author as we already have their name
  • Add some tracing for more visibility of progress.

Checklist

  • I have reviewed my own code
  • I have added tests

@voidpumpkin voidpumpkin added the meta Repository chores and tasks label Nov 9, 2022
@voidpumpkin voidpumpkin self-assigned this Nov 9, 2022
@futursolo futursolo merged commit 5355b65 into master Nov 9, 2022
hamza1311
hamza1311 approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@hamza1311 hamza1311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this now. Hopefully this will fix the issues. Any more fixes can come as their own PRs

@hamza1311 hamza1311 deleted the changelog-fix branch November 25, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@futursolo futursolo futursolo approved these changes

@github-actions github-actions[bot] github-actions approved these changes

@hamza1311 hamza1311 hamza1311 approved these changes

Assignees

@voidpumpkin voidpumpkin

Labels
meta Repository chores and tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@voidpumpkin @futursolo @hamza1311