Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to update app props #2951

Merged
merged 1 commit into from Nov 8, 2022

Conversation

WorldSEnder
Copy link
Member

Description

Add a method to AppHandle that updates the properties of the underlying component.
This is an independent part of #2858.

Checklist

  • I have reviewed my own code
  • I have added tests

@github-actions
Copy link

github-actions bot commented Nov 7, 2022

Visit the preview URL for this PR (updated for commit 9332226):

https://yew-rs-api--pr2951-update-app-props-e4sfvde4.web.app

(expires Mon, 14 Nov 2022 06:25:18 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@github-actions
Copy link

github-actions bot commented Nov 7, 2022

Benchmark - SSR

Yew Master

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 352.687 355.311 353.754 0.818
Hello World 10 622.033 624.389 623.033 0.735
Function Router 10 2210.193 2215.148 2212.044 1.589
Concurrent Task 10 1008.162 1009.805 1009.018 0.473

Pull Request

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 299.812 301.517 300.642 0.530
Hello World 10 611.160 613.232 612.075 0.636
Function Router 10 2149.222 2161.853 2155.708 3.987
Concurrent Task 10 1007.668 1009.745 1008.893 0.652

@github-actions
Copy link

github-actions bot commented Nov 7, 2022

Size Comparison

examples master (KB) pull request (KB) diff (KB) diff (%)
async_clock 106.161 106.161 0 0.000%
boids 170.390 170.385 -0.005 -0.003%
communication_child_to_parent 90.032 90.030 -0.002 -0.002%
communication_grandchild_with_grandparent 104.879 104.882 +0.003 +0.003%
communication_grandparent_to_grandchild 100.747 100.743 -0.004 -0.004%
communication_parent_to_child 87.134 87.133 -0.001 -0.001%
contexts 107.365 107.357 -0.008 -0.007%
counter 85.049 85.050 +0.001 +0.001%
counter_functional 85.522 85.521 -0.001 -0.001%
dyn_create_destroy_apps 87.910 87.911 +0.001 +0.001%
file_upload 99.644 99.645 +0.001 +0.001%
function_memory_game 162.893 162.886 -0.007 -0.004%
function_router 347.044 347.058 +0.014 +0.004%
function_todomvc 157.650 157.668 +0.018 +0.011%
futures 221.941 221.944 +0.003 +0.001%
game_of_life 104.578 104.576 -0.002 -0.002%
immutable 180.974 180.977 +0.003 +0.002%
inner_html 81.911 81.911 0 0.000%
js_callback 110.876 110.878 +0.002 +0.002%
keyed_list 195.522 195.527 +0.005 +0.002%
mount_point 84.659 84.658 -0.001 -0.001%
nested_list 111.623 111.618 -0.005 -0.004%
node_refs 92.535 92.531 -0.004 -0.004%
password_strength 1546.940 1546.948 +0.008 +0.001%
portals 95.952 95.942 -0.010 -0.010%
router 316.854 316.847 -0.007 -0.002%
simple_ssr 151.577 151.574 -0.003 -0.002%
ssr_router 392.123 392.130 +0.007 +0.002%
suspense 108.699 108.700 +0.001 +0.001%
timer 87.936 87.941 +0.006 +0.007%
todomvc 138.961 138.960 -0.001 -0.001%
two_apps 85.713 85.714 +0.001 +0.001%
web_worker_fib 152.045 152.046 +0.001 +0.001%
webgl 84.379 84.379 0 0.000%

✅ None of the examples has changed their size significantly.

Copy link
Member

@hamza1311 hamza1311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This method is definitely nice to have

@hamza1311 hamza1311 merged commit 3b4fa88 into yewstack:master Nov 8, 2022
@hamza1311 hamza1311 added A-yew Area: The main yew crate feature-accepted A feature request that has been accepted and needs implementing labels Nov 20, 2022
@WorldSEnder WorldSEnder mentioned this pull request Nov 25, 2022
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-yew Area: The main yew crate feature-accepted A feature request that has been accepted and needs implementing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants