Use keyed lists in tutorial example #2948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example should follow best practices such as using keyed lists.
|
Visit the preview URL for this PR (updated for commit 0faea9e): https://yew-rs--pr2948-patch-3-0f6ey24i.web.app (expires Mon, 14 Nov 2022 17:06:39 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
|
Can you also explain what the |
|
Added! |
WorldSEnder
requested changes
Nov 7, 2022
There was a problem hiding this comment.
The lines later in
yew/website/docs/tutorial/index.mdx
Lines 391 to 392 in c10fcc8
key prop added. Other than that, it looks good.
auto-merge was automatically disabled
November 7, 2022 16:57
Head branch was pushed to by a user without write access
WorldSEnder
approved these changes
Nov 8, 2022
hamza1311
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example should follow best practices such as using keyed lists.