Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cargo make pr-flow #2637

Closed
hamza1311 opened this issue Apr 22, 2022 · 1 comment · Fixed by #2640
Closed

Remove cargo make pr-flow #2637

hamza1311 opened this issue Apr 22, 2022 · 1 comment · Fixed by #2640
Labels
A-ci Area: The continuous integration

Comments

@hamza1311
Copy link
Member

hamza1311 commented Apr 22, 2022

This task is not what's actually run in CI. During development, it doesn't make sense to run it as it lints and tests everything which is CPU intensive and quite slow. It's better to just test the individual packages where changes are made and let CI handle testing everything (as it already does).

cargo make pr-flow really serves no purpose and can cause problems because everything is compiled together. See #2629 (comment) as an example of a problem it caused

The long, complicated commands such as wasm-pack test and run overwriting macro test outputs can have their own tasks:

packages/yew $ cargo make test
packages/yew-macro $ cargo make test
packages/yew-macro $ cargo make test-overwrite
@siku2
Copy link
Member

siku2 commented Apr 23, 2022

Yeah the command is mostly a left-over from when it was planned to switch over CI to cargo make as well. I'm in favor of removing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ci Area: The continuous integration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants