Router

[cemoktra]

Hi,

i started to develop an app based on the router sample. I reduced the routes to

• /login
• /404
• /! (home)

But going to /login/ always renders the same as home (/)
It logs:

 No route matched, provide a redirect prop to the router to handle cases where no route can be matched

Removing the trailing / from login route redirects to 404

[cemoktra]

Additional. Using yew 0.17 and yew-router 0.14

[teymour-aldridge]

This is a relatively common problem. "/" acts as a wildcard – what happens if you swap the order (I haven't had to work with the router for a while, so I've forgotten what the priority order is).

[cemoktra]

@siku2 yes that's missing

[siku2]

This is totally on me... I should've realised that many users would simply copy the code from the router example even though that code is fairly specific.
Do you think adding a comment which explains this in the code itself would help avoid this?

[cemoktra]

I think so. Also maybe printing a warning might help if the tag is necessary

[ranile]

FWIW, it might be a better idea to for router to support <base> tag natively without requiring all the code that the example adds.

[siku2]

FWIW, it might be a better idea to for router to support <base> tag natively without requiring all the code that the example adds.

Totally agree, I think I already wrote this down somewhere for router 2.0 since Trunk now supports this natively.