Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update jcabi parent 0.49.3 #966

Closed
fabriciofx opened this issue Dec 18, 2018 · 30 comments · Fixed by #991
Closed

Update jcabi parent 0.49.3 #966

fabriciofx opened this issue Dec 18, 2018 · 30 comments · Fixed by #991

Comments

@fabriciofx
Copy link

Let's update jcabi parent to 0.49.3 because Qulice still has been using 0.40 version.
@0crat
Copy link
Collaborator

0crat commented Dec 18, 2018

@krzyk/z please, pay attention to this issue

@0crat
Copy link
Collaborator

0crat commented Dec 18, 2018

@fabriciofx/z this project will fix the problem faster if you donate a few dollars to it; just click here and pay via Stripe, it's very fast, convenient and appreciated; thanks a lot!

korthout added a commit to korthout/qulice that referenced this issue Jan 19, 2019
@korthout
For yegor256#966 Update jcabi parent to 0.49.3
f92bbd5 
This update brought several problems, which failed the build.
They have all been resolved in this commit.

Release 0.48.5 brought a change to commons-collections,
this has been altered in the pom.xml.

Several IO methods have been deprecated. They implicitly
used `Charset.defaultCharset()`, so to keep it functionally
the same as before this change, I've made these usages
explicitly.

`StandardCharsets.UTF_8` is now the standard for JDK8+.

`Mockito.anyCollectionOf(File.class)` has been deprecated,
because since JDK8 `Mockito.anyCollection()` already deals
correctly with casting.
korthout added a commit to korthout/qulice that referenced this issue Jan 19, 2019
@korthout
For yegor256#966 Comply to qulice checks
aa714ad
korthout added a commit to korthout/qulice that referenced this issue Jan 21, 2019
@korthout
For yegor256#966 Use Cactoos alternatives to StringUtils
51bee60
korthout added a commit to korthout/qulice that referenced this issue Jan 23, 2019
@korthout
For yegor256#966 Replace defaultCharset with StandardCharsets.UTF_8
6551efa
krzyk added a commit to krzyk/qulice that referenced this issue Jan 24, 2019
@krzyk
yegor256#966 temporarly disable xcop
cfa5967
@krzyk krzyk mentioned this issue Jan 24, 2019
Merged
@krzyk
Copy link
Collaborator

krzyk commented Jan 24, 2019

@0crat assign @korthout

@0crat 0crat added the scope label Jan 24, 2019
@0crat
Copy link
Collaborator

0crat commented Jan 24, 2019

@0crat assign @korthout (here)

@krzyk The job #966 assigned to @korthout/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; @korthout/z is not a member of this project yet, but they can request to join, as §1 explains; there will be no monetary reward for this job

krzyk added a commit to krzyk/qulice that referenced this issue Jan 24, 2019
@krzyk
yegor256#966 fix travis
1d2e8e0
@0crat
Copy link
Collaborator

0crat commented Jan 24, 2019

Manual assignment of issues is discouraged, see §19: -5 point(s) just awarded to @krzyk/z

@0crat
Copy link
Collaborator

0crat commented Jan 24, 2019

Bug was reported, see §29: +15 point(s) just awarded to @fabriciofx/z

@0pdd 0pdd mentioned this issue Jan 24, 2019
Closed
@0pdd
Copy link
Collaborator

0pdd commented Jan 24, 2019

@fabriciofx the puzzle #1009 is still not solved.

@korthout
Copy link
Contributor

korthout commented Jan 27, 2019 •
edited

@fabriciofx I think this can be closed, because #991 has been merged.

@krzyk
Copy link
Collaborator

krzyk commented Jan 28, 2019

@korthout you need to ask fabriciofx for that

@fabriciofx
Copy link
Author

fabriciofx commented Jan 28, 2019 •
edited

@krzyk Closed by #991.

@0crat
Copy link
Collaborator

0crat commented Jan 28, 2019

Job #966 is not in the agenda of @korthout/z, can't retrieve data and time of add

@0crat
Copy link
Collaborator

0crat commented Jan 28, 2019

Job #966 is not in the agenda of @korthout/z, can't inspect

@0crat 0crat removed the scope label Jan 28, 2019
@0crat
Copy link
Collaborator

0crat commented Jan 28, 2019

The job #966 is now out of scope

@ypshenychka
Copy link

@0crat status

@0crat
Copy link
Collaborator

0crat commented Jan 29, 2019

@0crat status (here)

@ypshenychka This is what I know about this job in C3T49A35L, as in §32:

@ypshenychka
Copy link

@fabriciofx and @korthout According to our QA Rules:

Messages in a job always start with a name of a user they are addressed to

Please correct your messages by indicating an addressee in the beginning.

@ypshenychka
Copy link

@korthout According to our QA Rules:

Ticket must have references to all pull requests where the problem was actually fixed

Please add reference to PR. You can reference it by indicating this issue in PR's description.

@fabriciofx
Copy link
Author

fabriciofx commented Jan 29, 2019 •
edited

@ypshenychka Sorry, but the only message I didn't indicate an addressee was the first (which opens the ticket). Should I indicate it too? If yes, to who?

@ypshenychka
Copy link

@fabriciofx I mean this one.

@fabriciofx
Copy link
Author

@ypshenychka So, when a close an issue I should address it to who?

@ypshenychka
Copy link

@fabriciofx Either DEV or ARC.

@fabriciofx
Copy link
Author

@ypshenychka Ok. I'll fix it. Thanks!

@ypshenychka
Copy link

@fabriciofx thanks

@korthout korthout mentioned this issue Jan 29, 2019
Merged
@korthout
Copy link
Contributor

@ypshenychka done

@ypshenychka
Copy link

@korthout thanks

@ypshenychka
Copy link

@0crat quality acceptable

@0crat
Copy link
Collaborator

0crat commented Jan 29, 2019

@0crat quality acceptable (here)

@ypshenychka The project doesn't have enough funds, can't make a payment

@0crat
Copy link
Collaborator

0crat commented Jan 29, 2019

Order was finished, quality is "acceptable": +30 point(s) just awarded to @korthout/z

@0crat
Copy link
Collaborator

0crat commented Jan 29, 2019

Quality review completed: +8 point(s) just awarded to @ypshenychka/z

@0pdd
Copy link
Collaborator

0pdd commented Apr 30, 2019

@fabriciofx the only puzzle #1009 is solved here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

For #966 Update jcabi parent to 0.49.3 korthout/qulice
6 participants
@krzyk @fabriciofx @korthout @ypshenychka @0crat @0pdd