From 222019406af3a741efb49ac2bad42352bfde44ed Mon Sep 17 00:00:00 2001 From: ydah <13041216+ydah@users.noreply.github.com> Date: Wed, 8 Feb 2023 00:24:15 +0900 Subject: [PATCH] Use `line_with_comment?` instead of bad API `RuboCop::Cop::Util#comment_line?` is flagged by https://github.com/rubocop/rubocop/pull/8405 as a bad API. So I propose to fix not use this method. --- lib/rubocop/cop/rspec/mixin/empty_line_separation.rb | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/rubocop/cop/rspec/mixin/empty_line_separation.rb b/lib/rubocop/cop/rspec/mixin/empty_line_separation.rb index d22284fa8..6594908b0 100644 --- a/lib/rubocop/cop/rspec/mixin/empty_line_separation.rb +++ b/lib/rubocop/cop/rspec/mixin/empty_line_separation.rb @@ -25,8 +25,7 @@ def missing_separating_line_offense(node) def missing_separating_line(node) line = final_end_line = final_end_location(node).line - - while comment_line?(processed_source[line]) + while processed_source.line_with_comment?(line + 1) line += 1 comment = processed_source.comment_at_line(line) if DirectiveComment.new(comment).enabled?