forked from rubocop/rubocop-rails
-
Notifications
You must be signed in to change notification settings - Fork 0
/
duplicate_association.rb
56 lines (49 loc) · 1.75 KB
/
duplicate_association.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
# frozen_string_literal: true
module RuboCop
module Cop
module Rails
# This cop looks for associations that have been defined multiple times in the same file.
#
# When an association is defined multiple times on a model, Active Record overrides the
# previously defined association with the new one. Because of this, this cop's autocorrection
# simply keeps the last of any duplicates and discards the rest.
#
# @example
#
# # bad
# belongs_to :foo
# belongs_to :bar
# has_one :foo
#
# # good
# belongs_to :bar
# has_one :foo
#
class DuplicateAssociation < Base
include RangeHelp
extend AutoCorrector
include ClassSendNodeHelper
MSG = "Association `%<name>s` is defined multiple times. Don't repeat associations."
def_node_matcher :association, <<~PATTERN
(send nil? {:belongs_to :has_one :has_many :has_and_belongs_to_many} ({sym str} $_) ...)
PATTERN
def on_class(class_node)
offenses(class_node).each do |name, nodes|
nodes.each do |node|
add_offense(node, message: format(MSG, name: name)) do |corrector|
next if same_line?(nodes.last, node)
corrector.remove(range_by_whole_lines(node.source_range, include_final_newline: true))
end
end
end
end
private
def offenses(class_node)
class_send_nodes(class_node).select { |node| association(node) }
.group_by { |node| association(node).to_sym }
.select { |_, nodes| nodes.length > 1 }
end
end
end
end
end