Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trello::Member API isn't returning emails #537

Open
zacharyliu opened this issue Mar 27, 2018 · 1 comment
Open

Trello::Member API isn't returning emails #537

zacharyliu opened this issue Mar 27, 2018 · 1 comment

Comments

@zacharyliu
Copy link
Collaborator

zacharyliu commented Mar 27, 2018

Email addresses aren't getting returned in the API response to Trello::Member.find. There might be some missing permission.

This leads to some other subtle bugs, since User.from_trello tries to match the user by email address, which is the most accurate method. Since the email is missing, it has to try matching by full name or username, but some people's names don't match up. Normally users_from_card_data will update the User's trello_id to avoid this issue in the long term, but this never happens if a user never gets found in the first place. In the extreme case where none of the partners on a card match up, then CardSyncJob.users_from_card_data returns an empty array. And since [].present? == false, the sync job doesn't properly update the old list of partners.

@yasyf
Copy link
Owner

yasyf commented Mar 27, 2018

this might be bc trello now requires each user to OAuth (instead of using an administrator API key) in order to get their email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants