Fixes arbitrary file write on fetch #7831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CVE-2020-8131 was assigned. |
|
CVE-2020-8131 was published 2020-02-24, updated 2020-02-27, and is now appearing as a reason-for-failure during a code promotion job in our CI as reported by Anchore. How does a dependency-package (i.e. one installed with yarn) recover from this state? As a non-yarn user, I am unfamiliar with recovery options. With npm one would simply update npm, but since we aren't using yarn in our build cycle, I'm unsure what the best course of action is. |
|
@Gbl-peter I'm sorry, I have no idea what you mean. I suggest asking your devops team where they use Yarn, and ask them to upgrade. |
VincentBailly
pushed a commit
to VincentBailly/yarn
that referenced
this pull request
Jun 10, 2020
VincentBailly
pushed a commit
to VincentBailly/yarn
that referenced
this pull request
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In some circumstances it was possible to write files anywhere on the disk when running
yarn install. Although it's not that much of an issue considering that most installs are done with postinstall scripts, we don't want that to happen precisely to guarantee some level of safety for people actually using--ignore-scripts.Test plan
Will add tests after the release.