fix(workspaces): Pass args following "--" when running workspace scripts

[rally25rs]

fixes #7776

Summary

Arguments following a -- when running yarn workspaces run ... and yarn workspace package run ... were not being forwarded to the scripts.

Removed the commander.originalArgs nonsense that I introduced in a previous PR, and changed the workspace and workspaces commands to use args as already passed instead.

The yarn run command used args so it makes sense for workspace run to use args too.

I had to modify src/index.js's check for commands that should forward args and add workspace and workspaces to it. Again this is in-line with what already happened for the normal yarn run command.

As an added bonus, the normal scripts don't require "--" warning that yarn run normally prints, is now printed for workspace commands (it was not printed before this PR).

$ yarn workspaces run start -- one two
yarn workspaces v1.22.0-0
warning From Yarn 1.0 onwards, scripts don't require "--" for options to be forwarded. In a future version, any explicit "--" will be forwarded as-is to the scripts.

> pkg1
yarn run v1.22.0-0
$ ./start.sh one two
one two
Done in 0.07s.
Done in 0.32s.

Test plan

• Added unit tests to __tests__/index.js

• A manual test can be performed by setting up a basic workspace project:

package.json

{
  "name": "yarn-7776",
  "version": "1.0.0",
  "main": "index.js",
  "license": "MIT",
  "private": true,
  "workspaces": [
    "packages/*"
  ]
}

packages/pkg1/package.json

{
  "name": "pkg1",
  "version": "1.0.0",
  "main": "index.js",
  "license": "MIT",
  "scripts": {
    "start": "./start.sh"
  }
}

packages/pkg1/start.sh

#!/bin/bash
echo "ARGS: $@"

then run the yarn commands

yarn workspace pkg1 run start -- one two three
yarn workspace pkg1 run start one two three
yarn workspaces run start -- one two three
yarn workspaces run start one two three

The output from each should be ARGS: one two three

[rally25rs]

@arcanis do you know what the errors on circleci are all about?

    Error: Cannot find module '/tmp/tmp-124nBkpXZbh4tC6/JSON.stringify((() => require('no-deps'))())'

isn't very helpful... 😕

[arcanis]

My guess is that yarn node -p '...' is now incorrectly interpreted as yarn node '...', hence the Module not found on a JS script.

[rally25rs]

Ah, yeah, thanks for that help. The old logic had

      if (command === commands.run || command === commands.create) {
        preservedArgs += 1;

but in my changes I had applied having 1 preservedArgs to node as well. oops 🤦‍♂